picturepan2 / spectre

Spectre.css - A Lightweight, Responsive and Modern CSS Framework

Home Page:https://picturepan2.github.io/spectre/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Dart Sass 2.0.0

Valexr opened this issue · comments

Screenshot 2021-05-23 at 07 11 20

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation:

math.div($control-size-sm - $line-height, 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

Updates are requiered in icons-action as well.

Yep👌🏻I post code just for example… many places needs update 😁in this good css-framework 🤓
& dark theme will be nice👍🏻 now mix colours logic doesn’t allow make it with simple change based colours…

Hear me out, Sass is okay but writing math.div againts / is counter intutive to the whole sass thing that sass makes it easy. I didn't at all like this or sass. I never did more of a PostCSS person.

Though I would be glad to contribute for making dark and light theme, while keeping the size down but that might break the existing users of spectre.

I opened a PR (#669) few weeks ago to update the project to Dart Sass (use of @use instead of @import). I have recently seen the math.div warning on another project, and I think this can be done within my PR. But it seems that the project is no longer maintained, especially with the list of PRs waiting...

Why are they changing the syntax so much, not like they are adding any new feature.
I guess it is easier to just write css in js and transform it write from there and write it to a file. Then using any of the frameworks.

Simplest fix

npm install -g sass-migrator
sass-migrator division **/*.scss

If sir @picturepan2 is not going to update this, users can add

"postinstall": "sass-migrator division node_modules/spectre.css/src/*.scss"

and npm i -D sass-migrator, to fix this on userland.