picocss / pico

Minimal CSS Framework for semantic HTML

Home Page:https://picocss.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

aria-busy with tooltip unexpected rendering

Inveracity opened this issue · comments

Describe the issue

When tooltip and aria-busy are set on a button, the spinner looks funky

Current Behavior

A gif showing a button with aria-busy + tooltip and another button with aria-busy and no tooltip

output

Expected Behavior

I expected the spinner to appear inside the button

Reproduction

<main class="container">
  <section>
    <p>"busy" button with tooltip</p>
    <button aria-busy="true" data-tooltip="hello world" data-placement="bottom" />
  </section>
</main>

Environment

Pico CSS 1.5.11
Windows 10
Chrome Version 120.0.6099.130 (Official Build) (64-bit)

Thanks for making this awesome css framework

@Inveracity, I explored the problem, and it's impossible to fix, because both [data-tooltip] and [aria-busy] are using ::before.
The fallback will be cleaner in the v2. [aria-busy] wins.

Thanks for taking a look, much appreciated.
Excited for v2!