phpbb-extensions / boardrules

Board Rules extension for phpBB

Home Page:https://www.phpbb.com/customise/db/extension/boardrules/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

HHVM Test Failures

iMattPro opened this issue · comments

The HHVM test failures are due to rule_entity_message_test.php
The tests die without reporting errors, so it's hard to tell what it is exactly, but it most likely has to do with get_message_for_storage/edit/display() functions. HHVM tests also fail on functional test btw.

HHVM fails functional tests on most things. Can we set it not to run functional tests for HHVM please?

I'm not sure how to do that exactly, but it should resolve itself when they get it fixed for phpBB core.

The real problem is it failing on rule_entity_message_test.php which is not functional.

Update. The wonderful nicofuma found a bug and fixed it in HHVM tests, solving our failing issues with our code tests in rule_entity_message_test.php.

Now the only reason HHVM fails is on functional tests.

Closing this as HHVM test failures are out of our hands. It's up to phpBB developers to get HHVM working with phpBB's functional test case.