ToDo: Use BBCode Buttons new template include in the ACP
iMattPro opened this issue · comments
This PR is splitting the ACP BBcode buttons into a separate template: phpbb/phpbb#2290
After its merged, we can include the template instead of hard-coding the bbcode buttons too.
The above PR has been merged, but there are some problems with this.
The above PR is built around the large-scale editor in the ACP as seen in user signature and now also the contact page settings.
But our message editor is built on the (bbcode-less) small-scale editor as seen in forum rules.
So we can't really use it. Mainly because of the font color bbcode. We have this bbcode nestled in amongst all the bbcodes, and they do not, as for them, the color palette is in page..
I'm not sure what you mean about the differences, would you be able to get a screenshot of each to compare?
The core way (color palette is not in the post_buttons template file):
Board rules (our color palette is revealed by the font color button):
We could redesign the boardrules a little to have the message field the same as in the other image (which would make it the same as the contact info page and the board announcements page)
How about creating a pr for updating the one in phpbb? Theirs doesn't look
as nice
On Jun 9, 2014 6:27 PM, "Matt Friedman" notifications@github.com wrote:
The core way (color palette is not in the post_buttons template file):
[image: core]
https://cloud.githubusercontent.com/assets/303711/3224112/6dfb4328-f02d-11e3-97f2-fed399881904.pngBoard rules (our color palette is revealed by the font color button):
[image: boardrules]
https://cloud.githubusercontent.com/assets/303711/3224113/74a813ea-f02d-11e3-80c2-2758e7d0c1ec.png—
Reply to this email directly or view it on GitHub
#114 (comment)
.
That probably won't work, because theirs is as seen in acp users signature and contact form. It's not a little tiny box like we have, but full blown editor. Ours was based off a basic/mini message box as seen for creating forum rules. Now ours is based off the full blown! :)
Closing issue as this is now done.