Coding standards and editor.config
BladeMF opened this issue · comments
I forked this with the intention of contributing stuff when I have the time, but the first pull request failed to merge properly - it removed the entire file and then re-added it, which I think is due to whitespace and line ending issues. So (sorry, I am new to this):
- What line ending should I use?
- What indentation - type and width?
- Can I create an editor.config so it kinda comes with the repo?
What should I do about the .vscode folder (it has a local config in there and tasks that can be executed)?Sorry, I just saw it is already ignored.
Thanks for your help.
first pull request failed to merge properly - it removed the entire file and then re-added it
not sure what you mean here -- which pull request? in general nothing should automatically remove anything wen making a PR
What line ending should I use?
\n is standard (even on Windows now) I think.
What indentation - type and width?
Generally 2 spaces no tabs (I think this is what this repo uses)
Can I create an editor.config so it kinda comes with the repo?
Sure, assuming you mean https://editorconfig.org/
What should I do about the .vscode folder (it has a local config in there and tasks that can be executed)?
You can add it to the .gitignore file
Generally 2 spaces no tabs (I think this is what this repo uses)
The files seem to have 4.
Then 4 :) I copied this code from other VSCode extensions, so that's probably the standard there.
Agreed. It's your repo - it's whatever you say.