phpactor / coc-phpactor

Phpactor CoC Extension

Home Page:https://github.com/phpactor/phpactor

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Small bug with double "$" before variables and documentation inside menu

lukepass opened this issue · comments

Hello!
I think there are 2 small problems after the last update (maybe related to phpactor/phpactor#1775).

  • When completing the variable name a new "$" is added to the variable (please note the double "$" before $myCollection)
  • The completion menu contains the documentation and so it becomes quite difficult to read (at the end of the video you can se the first and other methods completion

I made a GIF to explain both problems:

Peek 2022-07-25 17-47

Thanks again.

hm, strange.

for the first see https://phpactor.readthedocs.io/en/master/lsp/vim.html#two-dollars-on-variables although that would not have been caused by that PR - and AFAIK I don't need this in my config.

For the second ... that looks very odd -- are you sure it's not custom config on your end?

testing with CoC - I get neither the $$ or the other issue:

image

But I also don't the documentation either, so maybe it is a config issue?

Hello! The first problem was solved by following your guide on phpactor:

autocmd FileType php set iskeyword+=$

The second one seems a problem only with GVim or Neovim-qt (so the GUIs), it doesn't show up using the terminal.

hm, does it happen also with other language servers?

As far as I can tell only for phpactor: JS is fine, CSS is fine, HTML is fine and PHP when using yaegassy/coc-intelephense is fine.
Please tell me if I can be of any help!

Thanks!