API Key in source code

Question

API Key in source code

RVxLab opened this issue 7 months ago · comments

This issue is more to provide visibility that the API key is currently in the source code. As @hrsa mentioned in #61, it’s a free key for ease of testing but it doesn’t mean it should be overlooked.

While not a big deal for now, better to have an open issue to remind everyone that this should probably be done.

Nuno Maduro · Answer 1 · Tue Oct 31 2023 19:35:08 GMT+0800 (China Standard Time)

@hrsa can you remove it?

RVxLab · Answer 2 · Tue Oct 31 2023 20:27:25 GMT+0800 (China Standard Time)

If hsra has no opportunity to remove it I can have a look tomorrow (AEST time).

@nunomaduro Are you intending to run this in a GH Action at all? If so I would vote adding an environment variable and/or a CLI longopt.

Anton Cherednichenko · Answer 3 · Tue Oct 31 2023 20:37:53 GMT+0800 (China Standard Time)

API key removed in 1f8a908 !

RVxLab · Answer 4 · Tue Oct 31 2023 20:43:46 GMT+0800 (China Standard Time)

Legend! I’ll close this issue now then.