php-translation / symfony-bundle

Symfony integration for Translations

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Deprecation: The "Symfony\Component\Console\Command\Command::$defaultName" property is considered final

axi opened this issue · comments

Since Symfony 6.1, relying on the static property "$defaultName" for setting a command name is deprecated (symfony/symfony@ca3458c)

The replacement way is to add Symfony\Component\Console\Attribute\AsCommand but php attributes are available for php8.0+ and this library supports php7.2+.

I could provide a PR for this change but that would remove support on php7.2+.
Is it wanted ? Maybe it's time to release a 1.x version ?

The ability to use PHP attributes to configure commands was introduced in Symfony 5.3 (see ref), so fixing this deprecation would also drop support for Symfony 4.4 and requires a bump of the 5.x branch: https://github.com/php-translation/symfony-bundle/blob/master/composer.json