Add CI tests if PR is installable with Symfony and Laravel

Question

Add CI tests if PR is installable with Symfony and Laravel

andig opened this issue 7 years ago · comments

Dimosthenis Nikoudis · Answer 1 · Mon Sep 17 2018 18:21:48 GMT+0800 (China Standard Time)

There is already something for this in travis from what I can see https://github.com/php-pm/php-pm-httpkernel/blob/master/.travis.yml#L20

Is this just a matter of adding
composer create-project laravel/laravel blog
and
composer create-project symfony/skeleton blog

in the script section in travis.yml?

andig · Answer 2 · Mon Sep 17 2018 18:45:14 GMT+0800 (China Standard Time)

Noticed the need during php-pm/php-pm#431.

Is this just a matter of adding...

The tricky part is installing the current PR into the generated framework project. Only approach I could find was fiddling with local composer repositories (https://getcomposer.org/doc/05-repositories.md#path)?

Dimosthenis Nikoudis · Answer 3 · Mon Sep 17 2018 21:25:29 GMT+0800 (China Standard Time)

Leaving Travis aside, what are the steps to reproduce those issues from scratch?

Create Symfony/Laravel project
cd to created project folder
composer require php-pm/httpkernel-adapter (with some fiddling with composer repos to ensure this pulls the PR instead of the live version)

Are these the correct steps to test?

Dimosthenis Nikoudis · Answer 4 · Mon Sep 17 2018 21:41:22 GMT+0800 (China Standard Time)

Actually now that I think of it, can't we just replace the line in travis.yml:
composer require --dev "symfony/symfony" "laravel/framework" "drupal/drupal"
with:
composer require --dev "symfony/framework-standard-edition" "laravel/laravel" "drupal/drupal"

This will widen the scope of the dependencies to what the actual frameworks install and should catch those conflicts.

Edit: To be more correct we should split this line to install laravel, symfony and drupal separately, since each framework may install conflicting dependencies with each other.