Test failure

Question

Test failure

remicollet opened this issue 8 years ago · comments

Remi Collet commented 8 years ago

There was 1 failure:

Warning
The data provider specified for Ds\Tests\MapTest::testSorted is invalid.
Method sortDataProvider does not exist
FAILURES!

Probably Map/sorted could be dropped (seems a duplicate of Map/sort), or the data provider name fixed.

Rudi Theunissen · Answer 1 · Thu Jul 28 2016 16:10:45 GMT+0800 (China Standard Time)

The trait for sort should have covered this mistake. What version of PHPUnit were you using? Was this when running all the tests?

Fixed in d53ada1

Remi Collet · Answer 2 · Thu Jul 28 2016 16:27:48 GMT+0800 (China Standard Time)

Was this when running all the tests?

Yes

But this appear only in some cases, probably related to files order (and to classmap used, generated by "phpab" instead of the composer one).

Remi Collet · Answer 3 · Thu Jul 28 2016 16:30:37 GMT+0800 (China Standard Time)

still some duplicate

$ phpab --output foo.php vendor/php-ds/tests/tests/
phpab 1.21.0 - Copyright (C) 2009 - 2016 by Arne Blankerts

Scanning directory vendor/php-ds/tests/tests/
Redeclaration of trait, interface or class found:

    Unit name: ds\tests\map\sort
    First occurance: /work/GIT/php-ds/vendor/php-ds/tests/tests/Map/sorted.php
    Redeclaration: /work/GIT/php-ds/vendor/php-ds/tests/tests/Map/sort.php

Even if composer is silent, this could obviously raise some issues.

Rudi Theunissen · Answer 4 · Thu Jul 28 2016 18:03:51 GMT+0800 (China Standard Time)

Okay, this should now be fixed in 6bed9cf

Remi Collet · Answer 5 · Thu Jul 28 2016 18:50:50 GMT+0800 (China Standard Time)

Indeed, fixed.

Rudi Theunissen · Answer 6 · Thu Jul 28 2016 18:51:27 GMT+0800 (China Standard Time)

Thanks for your help @remicollet