Giters

php-censor / docker-php-censor

Containers for PHP Censor CI system

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Testing and CI for image

ketchoop opened this issue · comments

commented
Testing and CI for image
commented

How can I assign this ticket to myself?

commented

I tried the installation in Windows with the Docker Toolbox v18.03. The installation went smoothly.

A few things that can be improved:

  1. Upgrade the docker composer file version to 3.
  2. Providing DB options is unnecessary. It should be assumed that if the consumer will be using the DB it will only be used for the PHP Censor software. If the consumer requires a specific DB they should provide it to the worker.
  3. By default, the DB container should be set up with a volume for storage. Otherwise, the database is lost when the container is disposed or rebuild.

Things I did not test:

  • Large test suites.
  • Multi worker and running build in parallel.
commented

@ptejada Thank you for the massive testing! 👍 Could you create issues or PRs for all your points please?