Issue updating past 2.1.3
johnnyshankman opened this issue · comments
Describe the bug
After updating from 2.1.3 to 2.1.4 I can no longer run my vitests within a react 18 + node v20 + vite 5 repo, as phosphor starts throwing import errors.
Steps to Reproduce
Upgrade from 2.1.3 to 2.1.4 and watch vitest fail to resolve imports within phosphor.
Expected behavior
No import issues in vitest, like in 2.1.3.
Screenshots
Context (please complete the following information):
"react": "^18.0.0",
"react-dom": "^18.0.0",
"react-router-dom": "^6.3.0"
"@phosphor-icons/react": "2.1.4",
"vite": "^5.2.7",
"vitest": "^1.4.0",
Error: Cannot find package '/Users/johnshankman/Documents/manifoldxyz/studio-app-devtools/node_modules/@phosphor-icons/react/dist/node_modules/.pnpm/react@18.2.0/node_modules/react/package.json' imported from /Users/johnshankman/Documents/manifoldxyz/studio-app-devtools/node_modules/@phosphor-icons/react/dist/node_modules/.pnpm/react@18.2.0/node_modules/react/cjs/react-jsx-runtime.production.min.mjs
Did you mean to import react/index.js?
Additional notes
Downgrading back to 2.1.0 exactly produces no issues.
Identified to be same issue as #90. Closing as duplicate, but fix incoming!
@rektdeckard thank you! cheers. apologies for the dupe.