(1.0.0-rc.0) Removed `phx-feedback-for` still around in documentation
rhcarvalho opened this issue · comments
Rodolfo Carvalho commented
Environment
- Elixir version (elixir -v): N/A
- Phoenix version (mix deps): N/A
- Phoenix LiveView version (mix deps):
1.0.0-rc.0
- Operating system: N/A
- Browsers you attempted to reproduce this bug on (the more the merrier): N/A
- Does the problem persist after removing "assets/node_modules" and trying again? Yes/no: N/A
Actual behavior
The documentation at https://hexdocs.pm/phoenix_live_view/1.0.0-rc.0 still has many references to phx-feedback-for
which is documented to be removed in 1.0 (breaking change).
Despite not in the search results above, phx-feedback-for
is also present in the cheatsheet https://hexdocs.pm/phoenix_live_view/1.0.0-rc.0/html-attrs.html.
Expected behavior
Need to update docs to point people towards the supported alternatives (including shim).
Steffen Deusch commented
Rodolfo Carvalho commented
Oh, sorry I missed 4643fc1 and thanks for the quick fix of the missing reference 💜