phoenixframework / phoenix_live_dashboard

Realtime dashboard with metrics, request logging, plus storage, OS and VM insights

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Max carrier size column behaviour

alexcastano opened this issue · comments

In the new "Memory Allocator" page we have the column Max carrier size. We use the max value returned by the BEAM.

image

However, the :observer.start() set the max value since the page is shown (or since the observer started), not from the start of the BEAM. I think we can reproduce the same behaviour by keeping a list of the max value per row, in a similar way we do to calculate the reductions:

def fetch_processes(node, search, sort_by, sort_dir, limit, prev_reductions \\ nil) do
search = search && String.downcase(search)
:rpc.call(node, __MODULE__, :processes_callback, [
search,
sort_by,
sort_dir,
limit,
prev_reductions
])
end

The question is, do we want that behavior? Or do we want an extra column?

I think following observer is the saner choice as they probably thought more and have more context than us. :)