mime 2.x support unintentionally dropped?
florish opened this issue · comments
Environment
Make sure you are using the latest LiveView and Dashboard versions before continuing.
- Elixir version (elixir -v): Elixir 1.12.3 (compiled with Erlang/OTP 24)
- Phoenix version (mix deps): 1.6.2
- Phoenix LiveView version (mix deps): 0.17.5
- Phoenix Dashboard version (mix deps): 0.6.1
- Operating system: macOS Big Sur 11.6
- Browsers you attempted to reproduce this bug on (the more the merrier): N/A
Actual behavior
On upgrading phoenix_live_dashboard after a fresh mix phx.new with Phoenix 1.6.2, I get the following output:
Unchanged:
phoenix 1.6.2
# (other deps omitted for reability)
Upgraded:
phoenix_live_dashboard 0.5.3 => 0.6.1 (minor)
phoenix_live_view 0.16.4 => 0.17.5 (minor)
Downgraded:
mime 2.0.2 => 1.6.0 (major)
* Updating phoenix_live_view (Hex package)
* Updating phoenix_live_dashboard (Hex package)
* Updating mime (Hex package)
As you can see, the mime library version is downgraded from 2.0.2 to 1.6.0.
Expected behavior
I'd expect the mime version not to drop as part of a phoenix_live_dashboard version upgrade.
Quick research learned me that mime 1.x support was an intentional choice not too long ago:
I'm opening this issue as I'd like to see mime 2.x also supported next to 1.x, which should be possible, given that there previously was no constraint.