Support "dark mode" theme

Question

Support "dark mode" theme

mcrumm opened this issue 3 years ago · comments

I am sure to be simplifying a bit, but I would like to explore adding a config option for dark_mode that is a boolean and we load a CSS file that is so named.

Edit: Adjusted for dark mode discussion

Michael Crumm · Answer 1 · Mon Nov 15 2021 00:33:08 GMT+0800 (China Standard Time)

// @archdragon

José Valim · Answer 2 · Mon Nov 15 2021 00:34:19 GMT+0800 (China Standard Time)

I am not a big fan of this approach because we have a non-reasonable amount of custom CSS, so what happens? Is this custom CSS meant to work with all possible themes? And then even if someone were to reimplement all of the CSS in a custom theme, what happens when we do a new version, where we add/change/remove classes? So to me this is all a bit too coupled for us to allow any theme to be plugged in.

Michael Crumm · Answer 3 · Mon Nov 15 2021 00:46:53 GMT+0800 (China Standard Time)

I will be honest– I made a naive assumption that things were mostly built-in.

I agree on all points. If the theme is not easily swappable then there is little benefit, and backwards compatibility is a real concern.

I am happy to close this as-is, but I wonder if any amount of "customization" is possible. For instance, would we accept a PR to support a "dark mode"?

José Valim · Answer 4 · Mon Nov 15 2021 01:08:04 GMT+0800 (China Standard Time)

We should accept a PR for a dark mode, yeah. :)