Improve tests

[Francis St-Amour]

Current tests are meh:

external-symbol-not-found/external-symbol-not-found.lisp

Lines 53 to 69 in 8f6b5f5

 (defun test () 
   #+(not (or sbcl ccl ecl abcl)) (not-supported-error) 
   (unwind-protect 
        (handler-case (progn 
                        (make-package 'test-package-12345 :use nil) 
                        (read-from-string "test-package-12345:symbol")) 
          (error (e) 
            (assert (external-symbol-not-found-p e)))) 
     (delete-package 'test-package-12345)) 
   (unwind-protect 
        (handler-case (progn 
                        (make-package 'test-package-12345 :use nil) 
                        (intern "SYMBOL" 'test-package-12345) 
                        (read-from-string "test-package-12345:symbol")) 
          (error (e) 
            (assert (external-symbol-not-found-p e)))) 
     (delete-package 'test-package-12345))) 

[Michał "phoe" Herda]

In particular, there should be a test which does (HANDLER-CASE ... (EXTERNAL-SYMBOL-NOT-FOUND (C) ...)) - since EXTERNAL-SYMBOL-NOT-FOUND is a defined type.

…

On 23.01.2022 15:05, Francis St-Amour wrote: Current tests are meh: https://github.com/phoe/external-symbol-not-found/blob/8f6b5f51c8cd853bad40ae5e7bddf50f547ce553/external-symbol-not-found.lisp#L53-L69 — Reply to this email directly, view it on GitHub <#1>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADSZHKULQERFDKICSTC7YZTUXQDJ3ANCNFSM5MTMHL3Q>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>