phlask / phlask-map

Code behind the Phlask Web Map

Home Page:https://beta.phlask.me

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

filter does not update map for water cooler or other not implemented types

tomporvaz opened this issue · comments

Describe the bug
When I choose a filter that has no data, nothing changes on the screen. For example, as demonstrated in the recording below, I choose a water filter of soda machine, but there is no change of which pins are displayed. This could indicate that all pins rendered are soda machines, but I think this is highly unlikely. I think it is more likely that soda machines is not an implemented tag, and the null result from this query is affecting no change.

To Reproduce

2023-12-28.14-15-23.mp4

Expected behavior
The map should show no pins or an error message to indicate that there are no results matching that filter.

Screenshots
n/a

Desktop (please complete the following information):
n/a

Smartphone (please complete the following information):
n/a

Additional context
Feature implemented in #215 and solution may be related to #344

This will be part of my new data schema PR #433

@vontell is making a big PR related to the new data schema that will address this issue soon.