Images for Featured Links

[Phil Sturgeon]

The new design has featured "cards" for ones we'd like to make more visible, but we could also consider adding images to them. Maybe using Twitter/React Bootstrap "Cards", or maybe some other way.

Should look ok with an without images.

[Rui Lima]

#117 o/

[Phil Sturgeon]

@rapzo hey there, do you think we could take another swing at this?

[Rui Lima]

Oh! Sorry mate. For real. I'll open a new PR before the end of the day! Sorry for sleeping again on this.

…

On Fri, Mar 13, 2020, 9:20 AM Phil Sturgeon ***@***.***> wrote: @rapzo <https://github.com/rapzo> hey there, do you think we could take another swing at this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#97 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABECTD5BRA6X4JUQ7434DDRHH3HPANCNFSM4J66EDUA> .

[Phil Sturgeon]

I appreciate it, and really no need to apologize. :D

[Rui Lima]

Question: could links.yaml be split into a collection? https://www.netlifycms.org/docs/collection-types/#folder-collections I think it would be easier to treat case by case, instead of having a massive file that gets changed in every change under netlify-cms

…

On Fri, 13 Mar 2020 at 11:11, Phil Sturgeon ***@***.***> wrote: I appreciate it, and really no need to apologize. :D — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#97 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABECTHELZUN6ASRQKGPDE3RHIIGBANCNFSM4J66EDUA> .

-- Rui Pedro Lima

[Phil Sturgeon]

This looks amazing, is it new? Are you able to do that?

…

On Fri, Mar 13, 2020 at 16:05, Rui Lima ***@***.***> wrote: Question: could links.yaml be split into a collection? https://www.netlifycms.org/docs/collection-types/#folder-collections I think it would be easier to treat case by case, instead of having a massive file that gets changed in every change under netlify-cms On Fri, 13 Mar 2020 at 11:11, Phil Sturgeon ***@***.***> wrote: > I appreciate it, and really no need to apologize. :D > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#97 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AABECTHELZUN6ASRQKGPDE3RHIIGBANCNFSM4J66EDUA> > . > -- Rui Pedro Lima — You are receiving this because you authored the thread. Reply to this email directly, [view it on GitHub](#97 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAAQONK4K7TPIJ5ZJ6LJIQLRHJKUHANCNFSM4J66EDUA).

[Rui Lima]

I think so. Still fighting with what gets uploaded and what gets transformed after using the cms. I reckon those links are also parsed for README purposes so, it might stretch a bit longer, but i'm about trying to do something with it. I managed to test the whole cms thingy and there were some errors: tags are mandatory and not all of'em have it. Once i get a working peace i'll get back here. But, just to let you know, i'm on it and will until it works ;-) On Fri, 13 Mar 2020 at 18:22, Phil Sturgeon <[e-mail]> wrote:

…

This looks amazing, is it new? Are you able to do that? On Fri, Mar 13, 2020 at 16:05, Rui Lima ***@***.***> wrote: > Question: could links.yaml be split into a collection? > https://www.netlifycms.org/docs/collection-types/#folder-collections > I think it would be easier to treat case by case, instead of having a > massive file that gets changed in every change under netlify-cms > > On Fri, 13 Mar 2020 at 11:11, Phil Sturgeon ***@***.***> > wrote: > >> I appreciate it, and really no need to apologize. :D >> >> — >> You are receiving this because you were mentioned. >> Reply to this email directly, view it on GitHub >> < #97 (comment) >, >> or unsubscribe >> < https://github.com/notifications/unsubscribe-auth/AABECTHELZUN6ASRQKGPDE3RHIIGBANCNFSM4J66EDUA > >> . >> > > -- > Rui Pedro Lima > > — > You are receiving this because you authored the thread. > Reply to this email directly, [view it on GitHub]( #97 (comment)), or [unsubscribe]( https://github.com/notifications/unsubscribe-auth/AAAQONK4K7TPIJ5ZJ6LJIQLRHJKUHANCNFSM4J66EDUA). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#97 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABECTGXVKNIM32PZ7VC2S3RHJ2WVANCNFSM4J66EDUA> .

-- Rui Pedro Lima

[Phil Sturgeon]

@rapzo I will hopefully migrate to collections today (#155)

[Rui Lima]

Are you working on it? I have it already. Can i open a PR for that?

…

On Tue, 17 Mar 2020 at 15:31, Phil Sturgeon ***@***.***> wrote: @rapzo <https://github.com/rapzo> I will hopefully migrate to collections today (#155 <#155>) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#97 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABECTHGOM7GGT5VAB6L773RH6JTRANCNFSM4J66EDUA> .

-- Rui Pedro Lima

[Phil Sturgeon]

@rapzo I was just about to start, thank you!! Yeah fire that PR over and we can merge so we can both work on top of it.

[Rui Lima]

Does this look good to you?

The picture was uploaded via netlify-cms and, after a while (a build), popped up there.
Everything should be automated via the cms now.

Just let me know how if the styles need work.

[Phil Sturgeon]

This is great! I am visually useless, so I am unsure how to handle having an uneven number or having some with images and some without. I suppose we can make it a requirement of being featured, if its not got an image some explosion happens somewhere on build?

Another approach would be rolling in #129 so that the first 3 featured links WITH images for (this country or global).

[Rui Lima]

Conditionals might be achievable with custom widgets. Don't know, have to play a bit more with it.
I'm reworking the queries in order to get an optimised version of the uploaded picture instead of the original.
Should have it done later today.

[Phil Sturgeon]

Thank you!