Shared layout

Question

Shared layout

philsturgeon opened this issue 5 years ago · comments

Add a layout which wraps both index and category pages, with a simple top nav and a github ribbon:

<a href="https://github.com/philsturgeon/awesome-earth"><img width="149" height="149" src="https://github.blog/wp-content/uploads/2008/12/forkme_left_green_007200.png?resize=149%2C149" class="attachment-full size-full" alt="Fork me on GitHub" data-recalc-dims="1"></a>

Zain Raza · Answer 1 · Tue Oct 15 2019 06:05:03 GMT+0800 (China Standard Time)

May I please help with this?

Phil Sturgeon · Answer 2 · Sun Oct 27 2019 06:22:40 GMT+0800 (China Standard Time)

@UPstartDeveloper please! Do you think you could do it in the next few days?

Zain Raza · Answer 3 · Sun Oct 27 2019 08:58:28 GMT+0800 (China Standard Time)

I'll get started on the navbar. I'll try to use Bootstrap for the website, since I just learned about the CSS framework this past few days at my college, Make School. Sorry for responding late.

Zain Raza · Answer 4 · Sun Oct 27 2019 11:38:43 GMT+0800 (China Standard Time)

My sincerest apologies, this will take longer than I thought. I am unsure of how to combine my bootstrap knowledge with the current project setup currently to use React.

Phil Mayne · Answer 5 · Mon Nov 04 2019 03:37:16 GMT+0800 (China Standard Time)

Hi @UPstartDeveloper one way of approaching this would be to look at creating a specific component which acts as a layout template. It simply dynamically wraps the component allowing for the layout to be reused. I could submit a PR for this issue if you wanted to take a look at this approach?

Zain Raza · Answer 6 · Mon Nov 04 2019 08:02:13 GMT+0800 (China Standard Time)

Thanks for the suggestion @ElRaymond0 ! Feel free to submit a PR. So far, I have been trying to figure out a way to use ReactStrap for the component, sorry for my lack of progress thus far.

Zain Raza · Answer 7 · Sun Dec 01 2019 09:39:54 GMT+0800 (China Standard Time)

Hey Philsturgeon/Awesome-Earth, I’m really sorry for not getting back to you on this. It’s totally my fault and I know it’s probably too late now, I just want you to know I didn’t mean to cause you any inconvenience. Hope you will understand that I just lost track of time. Sincerely, Zain Raza

…

On Sat, Nov 30, 2019 at 1:32 PM Phil Sturgeon ***@***.***> wrote: Closed #52 <#52>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#52?email_source=notifications&email_token=AIMIAPV3QOWSUWYZHIQFOHLQWLLXDA5CNFSM4JAIMAHKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVF2IKVI#event-2842985813>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIMIAPR4ZSZRYP3PJ5V3PILQWLLXDANCNFSM4JAIMAHA> .

Phil Sturgeon · Answer 8 · Sun Dec 01 2019 17:43:30 GMT+0800 (China Standard Time)

Not a problem at all @UPstartDeveloper! Please, this is a free site and eeryone is doing what they can when they can. Things come up and that's fine. This PR got done a little while ago we just forgot to close the ticket, so I'm glad you didn't do the work a second time only to find out it was done already! haha