philc / vimium

The hacker's browser.

Home Page:https://chrome.google.com/webstore/detail/vimium/dbepggeogbaibhgnhhndojpepiihcmeb

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Regression Bug] v2.1.0 Key exclusion popup

wenfangdu opened this issue · comments

Vimium: 2.1.0

Repro Steps:

  1. Exclude keys for a website and save changes
  2. Visit the website and evoke Vimium popup
  3. It shows no exclusion was configured

image

@philc

My mistake. It was introduced by the last commit before v2.1.0, and a hard bug to notice (the popup looks like it's still working). Note that existing exclusion rules still apply, and they're still editable on the Vimium Options page, but the popup itself does not function.

I've pushed v2.1.1 to the store which will fix this.

Note that existing exclusion rules still apply, and they're still editable on the Vimium Options page, but the popup itself does not function.

I think it's worse. Vimium (which I LOVE, btw) is active in Google Docs even though I have that url excluded.

@tammersaleh I confirmed on 2.1.0 that existing exclusion rules will still be applied even though the dialog isn't working, and in particular on docs.google.com. Can you post more details? What is the exclusion rule that you have defined, and what is the URL of your google docs site?