philc / vimium

The hacker's browser.

Home Page:https://chrome.google.com/webstore/detail/vimium/dbepggeogbaibhgnhhndojpepiihcmeb

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Encode spaces in %s in custom search URLs as %20 rather than +

philc opened this issue · comments

When a user has %s in one of their custom search engines, we encode spaces as + in the final URL.

+ is a less common encoding for space than %20, and is only valid in form inputs (i.e. in query string parameters). I've always preferred the appearance of + in URLs over %20 -- the + is easier to read as a separator -- but this StackOverflow post convinced me that we should just use %20.

I've seen a few reports over the years where some sites don't translate + characters in URLs into spaces. #4381 for example.

Fixed in 1e00ac5.