Related projects
sk- opened this issue · comments
Hi @phihag , I created yet another backport of ipaddress (https://github.com/sk-/backport_ipaddress). It was synced a couple of days ago and the changes to the original source code are minimal. You can diff with the sources in the original folder. And all the test pass.
I solved the bytes problem by using bytearray instead.
I took some ideas of another port https://bitbucket.org/kwi/py2-ipaddress/.
This is not really an issue, so feel free to close it.
Thank you for the note. May I ask what motivated you to create yet another backport? Since my code usually starts with from __future__ import unicode_literals (unless it's outright requiring 3.x), I don't pass in bytes by accident.
Two motivations, I wanted to have an updated backport and I wanted it to be as close to the original source as possible. My backport has only 30 different lines and 9 differnt lines in the test file. I commented out unused code instead of just removing it, as it is easier to compare with the sources and to update.
For example in your test_file there are many changes, specially because of the required use of u'...'.
I also noticed that in your backport you didn't change the lines except: which in Python 3 are equivalent to except Exception:. In Python 2 with a bare except you would also catch KeyboardInterrupt and SystemError.