Giters

phenax / bsp-layout

Manage layouts in bspwm (tall and wide)

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Second windowed open becomes Master with "rtall" layout

maetthew opened this issue · comments

commented

Hi,

Thanks for this project. I noticed something peculiar with the "rtall" layout in that the second opened window overtakes the Master window position. Moving the one single window I had opened be put in the "tall" stack. Any subsequent windows opened opens as expected.

I'll see if I can manage to solve this, but if not I thought I'd make an issue here.

commented

@darkelectron, can you check this out as well?

commented

Hi @maetthew 👋

@phenax, i'll have a look at that 😉

commented

hi @maetthew

Thanks for this project. I noticed something peculiar with the "rtall"
layout in that the second opened window overtakes the Master window
position. Moving the one single window I had opened be put in the "tall"
stack. Any subsequent windows opened opens as expected.

i think i've been able to reproduce the bug you mention here. can you confirm that? 😋

@phenax, are you ok if i work on that? 🙂

commented

a workaround, not final solution by any means, is to manually tile the second window to the left or to the bottom 🤔

commented

@a2n-s Hi, I'm not using bspwm anymore so unfortunately can't check.

commented

I'm not using bspwm anymore so unfortunately can't check.

no worries 😋
that is still a bug that needs to be addressed 💪

if you happen to use bspwm again before the issue is closed, feel free to share thoughts here 😉

commented

Can I piggyback on this issue? I have another small issue with rtall specifically, it does not do the horizontal split initially.

If I go to a desktop where I haven't applied any layout yet, and then apply rtall, it only resizes columns and does not apply any horizontal split. However, if I do another layout first, e.g. tall, that will correctly do columns and rows split and resize, and then I can do rtall and get the expected layout.

commented

hi @MikaelElkiaer 👋

i'm not sure i am able to reproduce the issue you mention 🤔

i open a bunch of windows on workspace 3 with the default "stair case" layout and then run ./build/bin/bsp-layout set rtall 3 from there and the layout applies correctly, with all the splits to the left and the master to the right!

suggestions

please share the following

  1. the version of bsp-layout
  2. how you installed it
  3. how you run it
  4. steps to reproduce and even a video would be amazing

i do not have that much time to work on a fix,
but hopefully we'll find the bugs 😌 💪 😉

commented

@amtoine Thanks for getting back to me, here is some more info:

  1. 0.0.10
  2. Installed via AUR package bsp-layout
  3. I run it via rofi: bsp-layout layouts | rofi -dmenu | xargs bsp-layout set
  4. I only experience it after a reboot, and for the first desktop where I try to switch layout to rtall. This is my usual flow for when it happens:
    1. Reboot OS and start bspwm with no desktops/windows
    2. Open 3 windows on desktop 1
    3. Use rofi script and choose rtall: windows are not split as expected - only vertically, no horizontal split for non-master column
    4. Use rofi script to choose tall: windows are now split both horizontally and vertically, with master window on the left
    5. Use rofi script to choose rtall: windows are now split as expected, with master window on the right
    6. Go to desktop 2, open 3 windows, use rofi script to choose rtall: windows are split as expected
commented

hey @MikaelElkiaer

@amtoine Thanks for getting back to me, here is some more info:

that's the purpose of me being here 😉 😋

The steps to reproduce

i did follow all your steps with both the 0.0.10-1 version from the AUR and the locally built git version from the repo
and i'm not able to reproduce the behaviour 🤔
i did reboot twice, did nothing but open 3 windows in desktop 1, ran your command with rtall and the windows are split horizontally the first time 😕 no need to go through tall and then rtall again...

PS: i like your simple rofi command, very handy 😋

commented

@amtoine Thanks for trying it out. There seems to be some timing involved as well, and I cannot reproduce it consistently. I will look into it at a later stage - only bothers me after a reboot.

commented

@amtoine Thanks for trying it out. There seems to be some timing involved as well, and I cannot reproduce it consistently. I will look into it at a later stage - only bothers me after a reboot.

feel free to give us updates on this if you find something 😉