Using Makefile instead of install script

Question

Using Makefile instead of install script

folliehiyuki opened this issue 4 years ago · comments

This will make it easier for a packager (and users) to control how things go into the system (through flags), instead of accepting the hard coded settings (man page path, binary path, ...).

Akshay Nair · Answer 1 · Fri Dec 04 2020 21:35:28 GMT+0800 (China Standard Time)

I agree. I've had this on my mind for some time. I'll work on this.

Hoang Nguyen · Answer 2 · Sun Dec 06 2020 15:43:55 GMT+0800 (China Standard Time)

Thanks for the quick response. I see you made the Makefile. Here is my preference, correct me if I'm wrong:

Using /usr/local as the default PREFIX is probably preferable
We can use cp -rf and ln -sf so that doing an uninstall before installing is not needed
chmod 755 is better than chmod +x (though they do the same thing here)
Small typo: echo "Unstalled bsp-layout"

Akshay Nair · Answer 3 · Sun Dec 06 2020 16:30:42 GMT+0800 (China Standard Time)

Thanks a lot for the suggestions! I'll add that in.
Currently the aur package is still using the install.sh script which internally uses the makefile. This is because I need to sort out the source import path inside the scripts first. I'll close this issue once that is done.

Hoang Nguyen · Answer 4 · Sun Dec 06 2020 16:52:42 GMT+0800 (China Standard Time)

Please ping me and make a release when you are done with it. I'll be happy to package this for Void Linux.

Akshay Nair · Answer 5 · Thu Dec 17 2020 00:28:22 GMT+0800 (China Standard Time)

@folliehiyuki, applied your suggestions. I've released 0.0.8 on github (Will create an AUR release tomorrow). The makefile now works with alternate prefixes.

Hoang Nguyen · Answer 6 · Thu Dec 17 2020 06:26:41 GMT+0800 (China Standard Time)

Nice. I think we can close this issue.

Looks good now.

Hoang Nguyen · Answer 7 · Fri Dec 18 2020 01:06:02 GMT+0800 (China Standard Time)

Hi again @phenax . I only noticed some problems when trying to package this. Can you fix the makefile?

VERSION = 0.0.5

Update the version here?

MAN_PATH = ${DESTDIR}${MANPREFIX}/man1
...
MANPAGE = ${DESTDIR}${MAN_PATH}/bsp-layout.1

The ${DESTDIR} is redundant here, which leads to problem when packaging using a fake $DESTDIR path.

And also can you bump to version 0.0.9 or something after fixing? That would be nice.

Akshay Nair · Answer 8 · Fri Dec 18 2020 01:18:15 GMT+0800 (China Standard Time)

Oops. My bad. I've released 0.0.9

Hoang Nguyen · Answer 9 · Fri Dec 18 2020 03:41:02 GMT+0800 (China Standard Time)

You still forgot to bump the version in the makefile :)
It doesn't affect anything so no need to fix immediately. It builds correctly now, thanks for fast response