keyframes kill the parser
biancashouse opened this issue · comments
When the css has @-webkit-keyframes, @moz-keyframes etc you get a null stylesheet from:
CollectingCSSParseErrorHandler aErrors = new CollectingCSSParseErrorHandler(new LoggingCSSParseErrorHandler());
final CascadingStyleSheet stylesheet = CSSReader.readFromString(cssFileContent, ECSSVersion.CSS30, aErrors);
Luckily, I can use the sourceforge CSSOMParser to extract the keyframes rules before running the remaing css through your parser.
In principle there is support for the keyframes in the parser. Can you please point me to an invalid CSS. Thanks
Also using the browser compliant mode as shown in #36 could be of help as well.
I think you'll find this causes the following to return a null stylesheet:
CollectingCSSParseErrorHandler aErrors = new CollectingCSSParseErrorHandler(
new LoggingCSSParseErrorHandler());
final CascadingStyleSheet stylesheet = CSSReader.readFromString(
cssFileContent, ECSSVersion.CSS30, aErrors);
https://www.simple.com/assets/stylesheets/styles.css
On Mon, Oct 24, 2016 at 6:37 PM, Philip Helger notifications@github.com
wrote:
In principle there is support for the keyframes in the parser. Can you
please point me to an invalid CSS. Thanks—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#35 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AArVxDp6Amr2PRmVgQcaEUjRx1YEZ50Aks5q3GBGgaJpZM4KeRnK
.
Ian White
h: +61 2 9948 9739
m: +61 404 950 122
hangout: biancashouse@gmail.com
Hi Ian!
I was running the parser against the test file (in version 5.0.2) and it was working without problems.
What version of ph-css are you using?
// Philip
Is there a way to build 5.0.2 with just java 1.7 ?
I can't start using 8 until appengine supports it.
On Wed, Oct 26, 2016 at 5:50 AM, Philip Helger notifications@github.com
wrote:
Hi Ian!
I was running the parser against the test file (in version 5.0.2) and it
was working without problems.
What version of ph-css are you using?
// Philip—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#35 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AArVxH5dTgB60dlSbVwZP_xdlB51lqLYks5q3k-PgaJpZM4KeRnK
.
Ian White
h: +61 2 9948 9739
m: +61 404 950 122
hangout: biancashouse@gmail.com
No way, It is build on libraries with Java 8 dependencies etc.
But go for 4.1.6 - this version already has the browser compliant mode. 4.1.6 is the version used in Apache JMeter so it should be good :)
Any news on this one?
apologies for the late reply.
i reverted to the old Java 7 version, and it is working fine.
i have moved onto another part of my code base, but will return to testing
the parser shortly...
On Sat, Nov 19, 2016 at 7:59 PM, Philip Helger notifications@github.com
wrote:
Any news on this one?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#35 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AArVxDnerdW0g4ayRpVOReAxIcOTQDZYks5q_rptgaJpZM4KeRnK
.
I close this one. If you're back on track, just reopen :)