mixing iv and accessors is quite strange
Ducasse opened this issue · comments
retrieveDetail
self mergeableMessage text: (self mergeableMessage text , ' Loading...' ).
self schedule: [
| detail mergeable |
[
detail := self pullRequest detail.
mergeable := detail at: #mergeable ]
on: Error do: [ :e |
mergeable := nil ].
mergeableMessage defer: [
mergeableMessage text: (self textForMergeable: mergeable) ].
mergeableIcon defer: [
mergeableIcon image: ( self iconForMergeable: mergeable) ] ]
activate -> 1
alert: -> 1
chooseFrom:values:message:title: -> 3
confirm: -> 1
confirm:label: -> 1
confirm:label:trueChoice:falseChoice:cancelChoice:default: -> 5
deactivate -> 1
defer: -> 3
deny: -> 80
inform: -> 2
inform:actionOnClick: -> 1
informUser:during: -> 18
informUserDuring: -> 3
questionWithoutCancel:title: -> 1
request:initialAnswer:title: -> 1
- defer: is ok
esteban
is self window inform: good? as in
IceTipToFiletreeToTonelDialog >> accept
"ensure window goes away (in case accept comes from a keybinding and not the ok button)"
self closeWindow.
selectedPackages ifEmpty: [
self window inform: 'No packages selected.'.
^ self ].
(self model newAddPackagesAction: selectedPackages)
executeWithContext: self