Giters

pgpool / pgpool2

This is the official mirror of git://git.postgresql.org/git/pgpool2.git. Note that this is just a *mirror* - we don't work with pull requests on github. Please subscribe to pgpool-hackers mailing list from our website and submit your patch to this mailing list.

Home Page:https://www.pgpool.net

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Similar branches

lexborisov opened this issue · comments

commented

Hello, everyone!

Same comparison in branching. Please, see line 773 and 780 of src/parser/outfuncs.c file.

if (node->jointype == JOIN_INNER) 
/* and */
else if (node->jointype == JOIN_INNER)
	if (node->jointype == JOIN_INNER) 
	{
		if (node->usingClause == NIL && node->quals == NULL && !node->isNatural)
			appendStringInfoString(str, " CROSS JOIN ");
		else
			appendStringInfoString(str, " JOIN ");
	}
	else if (node->jointype == JOIN_INNER)
		appendStringInfoString(str, " JOIN ");

Which is correct?

commented

@lexborisov Thank you for pointing out this issue.

line 780 should be deleted.

I have fixed this issue d34d808

commented

Thanks!