pgjones / flake8-sql

Flake8 plugin that checks SQL code against opinionated style rules

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Q447 root_keywords SELECT and FROM are not right aligned

opened this issue · comments

Hi!
I have this query:

CREATE OR REPLACE VIEW registration_list AS
         SELECT col1, col2, col3, col4, col5, col6, col7,
                col8, col9, SUBSTRING(col1 FROM 1 FOR 8) AS col10
              FROM table
           WHERE col5 IS NULL WITH CHECK OPTION

and the flake-8 kept giving me the error:
Q447 root_keywords SELECT and FROM are not right aligned
I tried many possibilities but i'm not able to remove the error, i would appreciate if you can help me in pointing the issue.

@pgjones can you help me out in this?

I think it is confused by the FROM in the SUBSTRING (although in the example the FROM isn't right aligned with the SELECT). I'm unsure how to fix this right now, so I'd add a # noqa Q447 to the line it notes as having the error.

so that's an issue right now? And yes this is what i thought as well because upon removing the SUBSTRING it was working fine. So we will let this issue remain open?

This should be fixed by d1a1000 and released in 0.4.0