Make IdentifierMap cache TTL configurable

Question

Make IdentifierMap cache TTL configurable

jlisthood opened this issue a year ago · comments

It would be nice if we could configure the TTL for the identifier cache in util/awsutil/rds.go. My org is hitting many issues with RDS API throttling on DescribeDBInstances calls and the top contender is pganalyze collector by far.

Seemingly, pganalyze collector is calling the AWS API just to read information that it already knows, i.e. the RDS identifier, so the API calls seem to be doing no real work.

Since we couldn't land on an optimization like the one in #349 , how do we feel about making the TTL for the cache configurable to the user? That way my org could set a higher TTL and reduce the API call frequency

Jesse Liston · Answer 1 · Fri Jan 27 2023 09:04:10 GMT+0800 (China Standard Time)

Actually, I believe this is now not relevant with #369

Jesse Liston · Answer 2 · Fri Jan 27 2023 09:10:43 GMT+0800 (China Standard Time)

@lfittl thanks for the #369, we are excited to try it out!

Lukas Fittl · Answer 3 · Fri Jan 27 2023 10:13:24 GMT+0800 (China Standard Time)

@jlisthood Great timing, and thanks for opening that PR initially - we should have the updated collector packages (v0.48.0) with this fix out later tonight.