Giters

pezcode / ighp

iTunes Global Hotkeys Plugin

Home Page:http://pezcode.github.com/ighp/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Not working in 12.11

Techn0core opened this issue · comments

commented

I selected the Global Hotkeys visualizer, and then selected Options. Nothing seems to happen. I haven't used your plugin before but I'm guessing a settings dialog window is supposed to open with textboxes etc. Really hoping I can get this to work.

Thanks!

2021-01-29_14-33-59.mp4
commented

Haven't used this plugin (or iTunes) in a while, but I'll take a look what's going on. I can reproduce it with 12.11, that should make it easy to troubleshoot.

commented

Turns out that the Options... button does nothing in recent iTunes versions anymore. The plugin simply doesn't get notified the user pressed the button.

I have three options, ordered by decreasing appeal:

  1. Show the settings dialog while the visualizer window is open. A little awkward but easy to implement.
  2. Render the settings dialog into the actual visualizer window. I'd prefer this but it seems rather complicated to implement properly.
  3. Use a hard-coded hotkey. Not optimal since that hotkey might already be taken by some other application and it can't be overridden.

Opinions?

commented

I would be perfectly happy with any of these really. Similar to option 3, can a visualizer plugin read from a configuration file? If so we could edit the file to specify the hotkeys we want to use.

Thanks for maintaining this, really appreciate it

commented

I've been trying to get this to work again today and was terrified to find out that Apple butchered the entire visual plugin interface to the point of requiring a substantial rewrite of this entire thing.

The plugin DLL is now loaded in a separate process, but only when the visualizer window is open. Once the visualizer is hidden, it shuts down the process, complete with the plugin. As a result the hotkeys don't get registered at startup and (owing to the way hotkeys work in Windows) even if you manually open the visualizer the hotkeys are deleted once the visualizer is gone. The only real way to fix this is to run a separate process in the background, at which point I'd be rewriting this existing program:
https://code.google.com/archive/p/hktunes/

So yeah... this program is officially broken I guess. And I don't see the point of rewriting it to not be a plugin that gets loaded at startup anymore, that was kind of the entire appeal. Sorry for getting your hopes up 😞 I'll add a note to the readme and archive this repository.