Change to Github Kingpin

Question

Change to Github Kingpin

jpopadak opened this issue 4 years ago · comments

Any chance the dependency on Kingpin can be changed to its GitHub equivalent? Doing anything with gopkg.in causes issues with Go modules & using a 3rd party Module Vendor.

https://github.com/alecthomas/kingpin/

For my local code, we have been using:
replace gopkg.in/alecthomas/kingpin.v2 => github.com/alecthomas/kingpin v2.2.6

Peter Götz · Answer 1 · Tue Dec 08 2020 06:30:30 GMT+0800 (China Standard Time)

Hey @jpopadak, yes, definitely. Sorry, I didn't realize there was an issue. Would mind submitting a PR with the change? I'll be happy to merge it.
Thanks,
Peter

Jim Popadak · Answer 2 · Fri Dec 11 2020 02:00:19 GMT+0800 (China Standard Time)

I am 90% sure this is an issue with our GOPROXY we are using. Kingpin itself states to use gopkg.in/alecthomas/kingpin.v2 itself. 🤷🏼

Peter Götz · Answer 3 · Wed Dec 16 2020 06:16:02 GMT+0800 (China Standard Time)

So what should we do? Will you investigate your GOPROXY settings, or would you prefer to use github.com/alecthomas/kingpin? If the latter, would you mind submitting a PR? If the former, should we close this issue and re-open if necessary?

Jim Popadak · Answer 4 · Wed Dec 16 2020 06:24:45 GMT+0800 (China Standard Time)

Lets close this for now. If it turns out to be an issue outside of our GOPROXY, I wil reopen.