small refactor to help create custom charts
habermanUIUC opened this issue · comments
There's a lot of reusable functionality inside
class _BarChartBase(DynamicRenderer): (charts.py)
that would be useful to create custom charts (not related to bar charts)
Describe the solution you'd like
Can you
- Rename _BarChartBase to _BaseChart
- export _BaseChart in
asciimatics/renderers/__init__.py - Update the two classes inside chart.py to use _BaseChart
Describe alternatives you've considered
Right now I just modify the source
Let me flip that around for a sec... If you're creating new chart renderers, would you be interested in adding them to the package?
I'll be happy to contribute. My use case is a bit different than how the current HBar and VBar work. I pass in a data generator object that provides a bit more information to the Chart Renderer than the array of functions that is currently being passed in. It also pushes the attributes down to the data level.
For example, for a scatter plot, the plot container can manage things like axis, outlines, legends, and how to do blending for when multiple points share the same screen coordinates. But the data generator(s) are responsible for what character, color to use for the values.
One scatterplot can also manage different data streams as well if you wanted to plot different data sets on the same plot.
Rather than refactor how HBar and VBar work, it might make more sense to just add this thing that I am creating as a new Chart type. Perhaps refactor the common into _BaseChart and have different family of charts (bar, scatter, area, etc) subclass off the _BaseChart
BUT for now I do subclass off of _BaseChart.
Sounds interesting... would be very happy to explore how to merge that into the project. Want to share some code and suggestions?
Yes. Let me refactor my stuff so I subclass off DynamicRenderer instead of _BarChartBase and we'll see how it goes.
Cool. I'll close this and you can submit the PR when you're ready.