Giters

peterbe / minimalcss

Extract the minimal CSS used in a set of URLs with puppeteer

Home Page:https://minimalcss.app/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Ability to set no-sandbox

peterbe opened this issue · comments

commented

When running inside a docker container, puppeteer might fail with this message:

STDERR Error: Failed to launch chrome!
[0205/134736.600483:ERROR:zygote_host_impl_linux.cc(90)] Running as root without --no-sandbox is not supported. See https://crbug.com/638180.

react-snap has this tip.

I think it would be nice to be able to tell minimalcss to set those options.

It would also be nice to understand what the disadvantage of those are. I.e. if using puppeteer.launch({args: ["--no-sandbox", "--disable-setuid-sandbox"]}) makes things work in virtualized containers, why not always run like that?