Add coordination number flag.

Question

Add coordination number flag.

frozzare opened this issue 5 years ago · comments

We need a flag on the ::Valid method making it possible to turn of validation for coordination number (+60 on day). The flag should default to enabling them as that is how it is currently working.

See personnummer/meta#9 for meta discussion.

Philip · Answer 1 · Mon Nov 18 2019 22:15:31 GMT+0800 (China Standard Time)

Just out of curiosity, why would someone want to disable "samordningsnummer"?

Fredrik Forsmo · Answer 2 · Mon Nov 18 2019 22:19:14 GMT+0800 (China Standard Time)

@arbitur not sure why.. personnummer/python#5

Philip · Answer 3 · Tue Nov 19 2019 18:52:03 GMT+0800 (China Standard Time)

That issue was created by someone not aware of what samordningsnummer is, I'd say it worked as intended for him. I vote against adding this flag.

Fredrik Forsmo · Answer 4 · Tue Nov 19 2019 18:54:06 GMT+0800 (China Standard Time)

Maybe, but it may be case where you want to disable this and we have a spec to follow for all implementations (see meta repo). It's not a big thing.

Philip · Answer 5 · Tue Nov 19 2019 18:58:38 GMT+0800 (China Standard Time)

Oh, I wasn't aware of the meta repo. I guess it's already settled then 👍

Philip · Answer 6 · Tue Nov 19 2019 18:59:24 GMT+0800 (China Standard Time)

I see now that I complettely missed you linked to meta.....