Giters

perl-workflow / perl-workflow

Workflow - simple, flexible system to implement workflows/state machines

Home Page:https://jonasbn.github.io/perl-workflow/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Address Perl::Critic violations

jonasbn opened this issue · comments

commented
  • Address the sections marked with ## no critic scattered throughout the code base, this might be valid, but another perspective and suggestions for refactorings might be a good idea (patches?)
  • follow up up Perl::Critic policies disabled and marked as TODO in the
    t/perlcriticrc file
  • Investigate whether use warnings pragma, breaks too much backwards
    compatibility [TestingAndDebugging::RequireUseWarnings]
  • Investigate violations of Perl::Critic policy [Subroutines::ProhibitExplicitReturnUndef]
  • Investigate violations of Perl::Critic policy [ValuesAndExpressions::ProhibitMagicNumbers]
commented

@jonasbn with some of the PRs addressed, could you check off the check marks you consider completed, or detail what's left for any that I PR-ed for?

commented

Ok, we still disable strictures in a few places as reported by TestingAndDebugging::ProhibitNoStrict

Stricture disabled at lib/Workflow/Factory.pm line 31
Stricture disabled at lib/Workflow/Factory.pm line 287
Stricture disabled at lib/Workflow/Factory.pm line 546
Stricture disabled at lib/Workflow/Config/Perl.pm line 84
Stricture disabled at lib/Workflow/Persister/File.pm line 155
commented

We should not have any issues with [TestingAndDebugging::RequireUseWarnings] since we are requiring Perl 5.14