penrose / penrose

Create beautiful diagrams just by typing notation in plain text.

Home Page:https://penrose.cs.cmu.edu

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

deleting a workspace then saving another one overrides other saved workspaces

KyleleeSea opened this issue · comments

Describe the bug
When you delete a locally saved workspace it highlights a previously saved workspace while putting the user in a separate unsaved workspace. If the user saves this workspace, it overrides the saved content in that highlighted workspace.

To Reproduce
Create two saved workspaces. Give them different content and titles to differentiate.
Delete the second workspace.
Observe the first workspace is highlighted, but the top bar says "Untitled Diagram"
Click "save" and observe the content of the first workspace gets overrided

Update: Additional bug, deleting a workspace does not update the diagram panel. If the deleted workspace had a diagram, the diagram remains shown in the diagram panel after deletion.

@KyleleeSea would you say that additional bug is part of this same bug, or is it distinct? If the latter, can you put it in a separate GitHub issue?

@samestep It's distinct, although the fix I have for it is one line and right below my fix for the other issue. I'm making a PR for my fix now. Should I still make a separate issue?

OK! Nah, if they're both just one-line fixes then don't worry about it. Thanks for catching this!