[Insight] Commented code should not be committed - in src/PelEntrySRational.php, line 133

[Lars Olesen]

in src/PelEntrySRational.php, line 133

Commented out code reduces readability and lowers the code confidence for other developers. If it's common usage for debug, it should not be committed. Using a version control system, such code can be safely removed.

        }

        switch ($this->tag) {
            case PelTag::SHUTTER_SPEED_VALUE:
                // CC (e->components, 1, v);
                // if (!v_srat.denominator) return (NULL);
                return Pel::fmt('%.0f/%.0f sec. (APEX: %d)', $v[0], $v[1], pow(sqrt(2), $v[0] / $v[1]));

            case PelTag::BRIGHTNESS_VALUE:
                // CC (e->components, 1, v);
                //

---

Posted from SensioLabsInsight