RangeError: Invalid WebSocket frame: RSV2 and RSV3 must be clear

Question

RangeError: Invalid WebSocket frame: RSV2 and RSV3 must be clear

tahayk opened this issue 2 years ago · comments

Kraiem Taha Yassine commented 2 years ago

I have been using PeerJS server for a couple of months, and sometimes I notice that the server crashes because of this error:

RangeError: Invalid WebSocket frame: RSV2 and RSV3 must be clear

Unfortunately I couldn't find a way to reproduce it, any idea how to handle it or fix it ?

Thank you in advance.

Jonas Gloning · Answer 1 · Sat Nov 05 2022 04:55:23 GMT+0800 (China Standard Time)

Thanks for the report!

I found an issue from the ws library with more information.
TLDR: Some clients sometimes send invalid frames. The websocket server is missing an error handler and crashing because of it.

The fix should be just 3 lines of code. I'll publish it in the next few days, probably just after the weekend.

Kraiem Taha Yassine · Answer 2 · Mon Nov 07 2022 19:07:22 GMT+0800 (China Standard Time)

@jonasgloning thank you very much, looking forward for the next release.

D · Answer 3 · Mon Nov 07 2022 21:30:06 GMT+0800 (China Standard Time)

I don't think is completed @tahayk - commits which updated some codestyling were created referencing this ticket and closed. There wasn't anything relating to this ticket yet... I'm also eagerly awaiting it :)

Jonas Gloning · Answer 4 · Mon Nov 07 2022 22:20:45 GMT+0800 (China Standard Time)

@intellix is right. I tried to create that commit on mobile - but the change didn't get saved, and the commit was mostly empty. I'll try again once I have access to a computer again.
Reopening this as a reminder :)

github-actions · Answer 5 · Thu Nov 10 2022 18:49:46 GMT+0800 (China Standard Time)

🎉 This issue has been resolved in version 1.0.0-rc.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Jonas Gloning · Answer 6 · Thu Nov 17 2022 04:35:02 GMT+0800 (China Standard Time)

Hey @tahayk, I found a way to to reproduce your error message:

const WebSocket = require('ws');

const ws = new WebSocket('ws://localhost:9000/peerjs?key=peerjs&id=peerjs&key=peerjs');

ws.on('open', () => ws._socket.write(Buffer.from([0x10])));

But the server doesn’t crash. Even very old versions are fine.

Can you tell me a bit more about your environment? I’m afraid without reproducing the crash; we can’t fix it.

RoundDiceChamp · Answer 7 · Thu Nov 17 2022 23:58:13 GMT+0800 (China Standard Time)

Hi @jonasgloning ,

maybe this helps. I'm able to reproduce the error with the following.

SERVER:

const express = require("express");
const { ExpressPeerServer } = require("peer");

const app = express();
app.on("error", (error) => console.error("Express error", error));

const server = app.listen(9000);
server.on("error", (error) => console.error("Server error", error));
server.on("clientError", (error) =>
  console.error("Server client error", error)
);

const peerServer = ExpressPeerServer(server);
peerServer.on("error", (error) =>
  console.error("ExpressPeerServer error", error)
);

app.use("/", peerServer);

CLIENT:

const WebSocket = require("ws");

const ws = new WebSocket("ws://localhost:9000/peerjs?key=peerjs&id=peerjs");

ws.on("error", (error) => console.error("Peer error", error));
ws.on("open", () => ws._socket.write(Buffer.from([0x10])));

The server then crushes with the following:
node:events:505
throw er; // Unhandled 'error' event
^

RangeError: Invalid WebSocket frame: RSV2 and RSV3 must be clear
at Receiver.getInfo (/Users/nope/repository/PeerTest/node_modules/ws/lib/receiver.js:171:14)
at Receiver.startLoop (/Users/nope/repository/PeerTest/node_modules/ws/lib/receiver.js:131:22)
at Receiver._write (/Users/nope/repository/PeerTest/node_modules/ws/lib/receiver.js:78:10)
at writeOrBuffer (node:internal/streams/writable:389:12)
at _write (node:internal/streams/writable:330:10)
at Receiver.Writable.write (node:internal/streams/writable:334:10)
at Socket.socketOnData (/Users/nope/repository/PeerTest/node_modules/ws/lib/websocket.js:1162:35)
at Socket.emit (node:events:527:28)
at addChunk (node:internal/streams/readable:315:12)
at readableAddChunk (node:internal/streams/readable:289:9)
Emitted 'error' event on WebSocket instance at:
at Receiver.receiverOnError (/Users/nope/repository/PeerTest/node_modules/ws/lib/websocket.js:1049:13)
at Receiver.emit (node:events:527:28)
at emitErrorNT (node:internal/streams/destroy:157:8)
at emitErrorCloseNT (node:internal/streams/destroy:122:3)
at processTicksAndRejections (node:internal/process/task_queues:83:21) {
code: 'WS_ERR_UNEXPECTED_RSV_2_3',
[Symbol(status-code)]: 1002
}

Kraiem Taha Yassine · Answer 8 · Fri Nov 18 2022 00:13:01 GMT+0800 (China Standard Time)

Hey @jonasgloning, I couldn't reproduce the error with your code,
I'm running a docker container, everything is here: https://github.com/openreplay/openreplay/tree/main/peers
I'm using peerjs-server with expressjs

Jonas Gloning · Answer 9 · Fri Nov 18 2022 04:13:46 GMT+0800 (China Standard Time)

I could reproduce the crash with the code from @RoundDiceChamp, thanks!

New beta is on npm: https://github.com/peers/peerjs-server/releases/tag/v1.0.0-rc.4

Kraiem Taha Yassine · Answer 10 · Tue Nov 22 2022 02:02:50 GMT+0800 (China Standard Time)

Thank you very much @jonasgloning
I have been using v1.0.0-rc.4 for the past 3 days, so far no issues,
except that I'm still getting this issue:

RangeError: Invalid WebSocket frame: RSV2 and RSV3 must be clear
     at Receiver.getInfo (/work/node_modules/ws/lib/receiver.js:171:14)
     at Receiver.startLoop (/work/node_modules/ws/lib/receiver.js:131:22)
     at Receiver._write (/work/node_modules/ws/lib/receiver.js:78:10)
     at writeOrBuffer (node:internal/streams/writable:390:12)
     at _write (node:internal/streams/writable:331:10)
     at Receiver.Writable.write (node:internal/streams/writable:335:10)
     at Socket.socketOnData (/work/node_modules/ws/lib/websocket.js:1162:35)
     at Socket.emit (node:events:527:28)
     at addChunk (node:internal/streams/readable:324:12)
     at readableAddChunk (node:internal/streams/readable:297:9) {
   code: 'WS_ERR_UNEXPECTED_RSV_2_3',
   [Symbol(status-code)]: 1002
 }

but this time I'm able to catch it using the following code: (it wasn't possible before):

const app = express();
const server = app.listen(PORT, HOST, () => {
    console.log(`App listening on http://${HOST}:${PORT}`);
});

const peerServer = ExpressPeerServer(server, {
    debug: true,
    path: '/',
    proxied: true,
    allow_discovery: false
});

const peerError = (error) => {
    console.error('Error type:');
    console.error(error.type);
    console.error('Error message:');
    console.error(error);
}
peerServer.on('error', peerError);

github-actions · Answer 11 · Tue Jan 10 2023 04:31:03 GMT+0800 (China Standard Time)

🎉 This issue has been resolved in version 1.0.0-rc.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions · Answer 12 · Wed Mar 08 2023 03:30:06 GMT+0800 (China Standard Time)

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions · Answer 13 · Tue Apr 02 2024 02:04:12 GMT+0800 (China Standard Time)

🎉 This issue has been resolved in version 1.1.0-rc.1 🎉

The release is available on:

Your semantic-release bot 📦🚀