Error in function cutoff_first_bin
aaolaveh opened this issue · comments
Hi Matt, there is a little issue in cutoff_first_bin
when check_skew =TRUE
.
When the condition
sum(bin_idx[1L:(mid-1L)]) < sum(bin_idx[mid:num_bins])
is true (left-skewed) it returns
as.vector(cutree(hcl, k = 1L))
but it should return the height where the tree should be cut , i.e
max(hcl$height)
As it is, construct_pullback()
returns error
Thanks and best regards