pedsmoreira / battlecry

Open source scaffolding CLI for everyone

Home Page:https://battlecry.js.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

joinLines() using \r\n instead of \n

Jimmerz28 opened this issue · comments

Currently joinLines() adds \r\n to the end of each line, which isn't really optimal as some environments lint to ensure line endings are only \n.

It would be best if joinLines() either used [os.EOL](https://nodejs.org/api/os.html#os_os_eol) or offered an option via config of which line endings we wanted battlecry to use when writing/appending to files.

👍, would you like to give it a shot and open a PR?

Closing this issue, as it was fixed by your PR #12