Ruby 3 support

Question

Ruby 3 support

morigs opened this issue 3 years ago · comments

It seems that this gem doesn't support Ruby 3.
Or it crashes on my PC for some other reason.

$ coltrane
/home/morigs/.asdf/installs/ruby/3.0.0/lib/ruby/gems/3.0.0/gems/gambiarra-0.0.3/lib/gambiarra/router.rb:32:in `build_url'
/home/morigs/.asdf/installs/ruby/3.0.0/lib/ruby/gems/3.0.0/gems/gambiarra-0.0.3/lib/gambiarra/router.rb:19:in `get'
/home/morigs/.asdf/installs/ruby/3.0.0/lib/ruby/gems/3.0.0/gems/gambiarra-0.0.3/lib/gambiarra/app.rb:82:in `flow'
/home/morigs/.asdf/installs/ruby/3.0.0/lib/ruby/gems/3.0.0/gems/gambiarra-0.0.3/lib/gambiarra/app.rb:26:in `block in start'
/home/morigs/.asdf/installs/ruby/3.0.0/lib/ruby/gems/3.0.0/gems/gambiarra-0.0.3/lib/gambiarra/app.rb:26:in `loop'
/home/morigs/.asdf/installs/ruby/3.0.0/lib/ruby/gems/3.0.0/gems/gambiarra-0.0.3/lib/gambiarra/app.rb:26:in `start'
/home/morigs/.asdf/installs/ruby/3.0.0/lib/ruby/gems/3.0.0/gems/coltrane-4.0.6/exe/coltrane:24:in `<top (required)>'
/home/morigs/.asdf/installs/ruby/3.0.0/bin/coltrane:23:in `load'
/home/morigs/.asdf/installs/ruby/3.0.0/bin/coltrane:23:in `<main>'
wrong number of arguments (given 1, expected 2)
/home/morigs/.asdf/installs/ruby/3.0.0/lib/ruby/gems/3.0.0/gems/gambiarra-0.0.3/lib/gambiarra/app.rb:26:in `block in start': no implicit conversion of nil into Hash (TypeError)
        from /home/morigs/.asdf/installs/ruby/3.0.0/lib/ruby/gems/3.0.0/gems/gambiarra-0.0.3/lib/gambiarra/app.rb:26:in `loop'
        from /home/morigs/.asdf/installs/ruby/3.0.0/lib/ruby/gems/3.0.0/gems/gambiarra-0.0.3/lib/gambiarra/app.rb:26:in `start'
        from /home/morigs/.asdf/installs/ruby/3.0.0/lib/ruby/gems/3.0.0/gems/coltrane-4.0.6/exe/coltrane:24:in `<top (required)>'
        from /home/morigs/.asdf/installs/ruby/3.0.0/bin/coltrane:23:in `load'
        from /home/morigs/.asdf/installs/ruby/3.0.0/bin/coltrane:23:in `<main>'

Pedro Maciel · Answer 1 · Mon Jan 18 2021 22:06:58 GMT+0800 (China Standard Time)

Hey, I did some changes. Please try the newest gem version v4.1.0 and lemme know if it works :)

Igor Morozov · Answer 2 · Tue Jan 19 2021 00:30:03 GMT+0800 (China Standard Time)

Hi. I've upgraded gem, but still getting the same error

Pedro Maciel · Answer 3 · Tue Feb 09 2021 07:11:42 GMT+0800 (China Standard Time)

check now please

Pedro Maciel · Answer 4 · Tue Feb 09 2021 07:11:57 GMT+0800 (China Standard Time)

latest version, 4.1.1

Igor Morozov · Answer 5 · Tue Feb 09 2021 14:33:42 GMT+0800 (China Standard Time)

Still have the same error 😢

Pedro Maciel · Answer 6 · Tue Feb 09 2021 19:29:55 GMT+0800 (China Standard Time)

I'm sorry about that. Can you post the new error trace?

Igor Morozov · Answer 7 · Wed Feb 10 2021 14:42:57 GMT+0800 (China Standard Time)

Looks the same

Logs

This terminal doesn't seem to support true color. Try something like iTerm2 (for macOS), VTE or Konsole (for linux) or Hyper (for Windows) and you'll see the true magic!
/home/morigs/.asdf/installs/ruby/3.0.0/lib/ruby/gems/3.0.0/gems/gambiarra-0.0.3/lib/gambiarra/router.rb:32:in `build_url'
/home/morigs/.asdf/installs/ruby/3.0.0/lib/ruby/gems/3.0.0/gems/gambiarra-0.0.3/lib/gambiarra/router.rb:19:in `get'
/home/morigs/.asdf/installs/ruby/3.0.0/lib/ruby/gems/3.0.0/gems/gambiarra-0.0.3/lib/gambiarra/app.rb:82:in `flow'
/home/morigs/.asdf/installs/ruby/3.0.0/lib/ruby/gems/3.0.0/gems/gambiarra-0.0.3/lib/gambiarra/app.rb:26:in `block in start'
/home/morigs/.asdf/installs/ruby/3.0.0/lib/ruby/gems/3.0.0/gems/gambiarra-0.0.3/lib/gambiarra/app.rb:26:in `loop'
/home/morigs/.asdf/installs/ruby/3.0.0/lib/ruby/gems/3.0.0/gems/gambiarra-0.0.3/lib/gambiarra/app.rb:26:in `start'
/home/morigs/.asdf/installs/ruby/3.0.0/lib/ruby/gems/3.0.0/gems/coltrane-4.1.1/exe/coltrane:24:in `'
/home/morigs/.asdf/installs/ruby/3.0.0/bin/coltrane:23:in `load'
/home/morigs/.asdf/installs/ruby/3.0.0/bin/coltrane:23:in `'
wrong number of arguments (given 1, expected 2)
/home/morigs/.asdf/installs/ruby/3.0.0/lib/ruby/gems/3.0.0/gems/gambiarra-0.0.3/lib/gambiarra/app.rb:26:in `block in start': no implicit conversion of nil into Hash (TypeError)
        from /home/morigs/.asdf/installs/ruby/3.0.0/lib/ruby/gems/3.0.0/gems/gambiarra-0.0.3/lib/gambiarra/app.rb:26:in `loop'
        from /home/morigs/.asdf/installs/ruby/3.0.0/lib/ruby/gems/3.0.0/gems/gambiarra-0.0.3/lib/gambiarra/app.rb:26:in `start'
        from /home/morigs/.asdf/installs/ruby/3.0.0/lib/ruby/gems/3.0.0/gems/coltrane-4.1.1/exe/coltrane:24:in `'
        from /home/morigs/.asdf/installs/ruby/3.0.0/bin/coltrane:23:in `load'
        from /home/morigs/.asdf/installs/ruby/3.0.0/bin/coltrane:23:in `'

Fedor Koshel · Answer 8 · Wed Feb 10 2021 15:00:22 GMT+0800 (China Standard Time)

It can be a problem with the asdf ruby build or with the gambiarra gem. Try to install ruby with rbenv/rwm and make bundle install. I've tested it on my machine with rbenv and everything works fine. Or, maybe, bundle update can help.

$ ruby -v       
ruby 3.0.0p0 (2020-12-25 revision 95aff21468) [x86_64-linux]
$ ./bin/coltrane       
? Welcome to Coltrane 4.1.1 (Choose with ↑ ↓ ⏎, filter with 'f')
> 1. notes
  2. chords
  3. scales
  4. progressions
  5. exit

ps. I've used master branch, commit c05d407962470ed2eb7894012f02fed76a25a106 for the test

Igor Morozov · Answer 9 · Thu Feb 11 2021 15:12:36 GMT+0800 (China Standard Time)

bundle install did a trick! Thanks a lot 😄