pedroSG94 / RTSP-Server

Plugin of rtmp-rtsp-stream-client-java to stream directly to RTSP player.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

onConnectionSuccessRtsp is never called

MalteHillmann opened this issue · comments

Hi!

The function onConnectionSuccessRtsp is never called when using RTSP-Server.

In RtspClient.kt is a call here:
https://github.com/pedroSG94/rtmp-rtsp-stream-client-java/blob/3bbdd59707855d4ccdbaea319583716ae3f5235d/rtsp/src/main/java/com/pedro/rtsp/rtsp/RtspClient.kt#L284

In RtspSender.kt is only a call to onConnectionFailedRtsp but no call to onConnectionSuccessRtsp.
https://github.com/pedroSG94/rtmp-rtsp-stream-client-java/blob/3bbdd59707855d4ccdbaea319583716ae3f5235d/rtsp/src/main/java/com/pedro/rtsp/rtsp/RtspSender.kt#L156

I think
connectCheckerRtsp.onConnectionSuccessRtsp()
should be called right after this:

Otherwise adaptive video bitrate can only be used with a workaround on RTSP-Server.

Thank you.

Kind regards
Malte

Fixed here: 70b9d56

Re open issue if needed