seeds.rb uses #create instead of #create!

Question

seeds.rb uses #create instead of #create!

nachokb opened this issue 10 years ago · comments

Doc says "At this point, your seeds file will be rewritten with all the create! statements". But I see it's using #create (and thus failing silently).

Bhavin Javia · Answer 1 · Mon Feb 23 2015 15:40:12 GMT+0800 (China Standard Time)

+1. We are in the process of migrating our seeds to this gem and seeing create instead of create! in the generated seeds file makes me nervous

Pierre Jambet · Answer 2 · Mon Feb 23 2015 22:55:46 GMT+0800 (China Standard Time)

Hi,

I'm really sorry I didn't reply earlier.
Indeed the README is wrong about create!.
I think the best solution would be to add a new config so you can choose if it uses the ! or not. If any of you wants to take of that, I'd be happy to merge a PR, otherwise I'll try to do that soon.

Thanks again.

Pierre Jambet · Answer 3 · Tue Dec 01 2015 06:20:57 GMT+0800 (China Standard Time)

Just updated the README.

Pierre Jambet · Answer 4 · Tue Dec 01 2015 07:11:41 GMT+0800 (China Standard Time)

Just merged #36 which adds a new option use_strict_create. I'll publish 1.1.0 soon.