pbaity / rocketchat-dark-mode

An easy user-togglable dark mode for Rocket.Chat

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Rocket.Chat 4.3.0

ae5960e8-a6fc-491f-b252-898ecf59af95 opened this issue · comments

Rocket.Chat 4.3.0 is out, some elements of the script need to be updated to accommodate the new changes.

  • Message options menu (three dots) text is unreadable on hover
  • Account menu (clicking account icon)
  • Message Info "OK" button
  • Video Conference “Cancel” button
  • 2FA backup code box after enabling 2FA
  • Likely more I have missed.

I started working on 4.3.0 modifications to update the dark mode, here are some elements :

  • Message options menu -> fixed
  • Account menu -> unable to see the issue, can you provide a screenshot ?
  • Message info OK button -> unable to see the issue, can you provide a screenshot ?
  • Video Conference "Cancel" button -> RC issue, this button is missing rcx-button--ghost class (should we open a PR ?)
  • 2FA -> not tested yet
  • I found some other elements, I'll update this asap

Account menu:
1

Message info OK button:
2

These issues were fixed in #162 . If you find any other specific problems, feel free to open new issues for those.

@ae5960e8-a6fc-491f-b252-898ecf59af95 Can you check if "Message info OK button" is fixed ? If not, where should I go to display that popup/modal ?