Fix govet errors in worker pool template

Question

jscharber opened this issue 4 years ago · comments

don't pass sync or mutex as value
remove unreachable code

Solomon Gayle · Answer 1 · Mon Mar 16 2020 00:44:51 GMT+0800 (China Standard Time)

John, Do you also want the unhandled errors in the _test.go files fixed?

-Solomon

On Fri, Mar 13, 2020 at 11:53 AM John Scharber ***@***.***> wrote: Assigned #65 <#65> to @shgayle <https://github.com/shgayle>. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#65 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANA4GPG5D3SGVSI4CQOBBN3RHJJHFANCNFSM4KRE47GA> .

John Scharber · Answer 2 · Mon Mar 16 2020 01:28:54 GMT+0800 (China Standard Time)

Not right now, we have other things to work on. On Sun, Mar 15, 2020 at 9:45 AM Solomon Gayle <notifications@github.com> wrote:

John, Do you also want the unhandled errors in the _test.go files fixed? -Solomon On Fri, Mar 13, 2020 at 11:53 AM John Scharber ***@***.***> wrote: > Assigned #65 <#65> to > @shgayle <https://github.com/shgayle>. > > — > You are receiving this because you were assigned. > Reply to this email directly, view it on GitHub > <#65 (comment)>, or > unsubscribe > < https://github.com/notifications/unsubscribe-auth/ANA4GPG5D3SGVSI4CQOBBN3RHJJHFANCNFSM4KRE47GA > > . > — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#65 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAM4YWSXYC2MQGGUZO3LXCDRHUAY7ANCNFSM4KRE47GA> .

Solomon Gayle · Answer 3 · Mon Mar 16 2020 01:30:40 GMT+0800 (China Standard Time)

Understood.

-Solomon On Sun, Mar 15, 2020 at 1:29 PM John Scharber <notifications@github.com> wrote:

Not right now, we have other things to work on. On Sun, Mar 15, 2020 at 9:45 AM Solomon Gayle ***@***.***> wrote: > John, > > Do you also want the unhandled errors in the _test.go files fixed? > > -Solomon > > On Fri, Mar 13, 2020 at 11:53 AM John Scharber ***@***.*** > > wrote: > > > Assigned #65 <#65> to > > @shgayle <https://github.com/shgayle>. > > > > — > > You are receiving this because you were assigned. > > Reply to this email directly, view it on GitHub > > <#65 (comment)>, or > > unsubscribe > > < > https://github.com/notifications/unsubscribe-auth/ANA4GPG5D3SGVSI4CQOBBN3RHJJHFANCNFSM4KRE47GA > > > > . > > > > — > You are receiving this because you were assigned. > Reply to this email directly, view it on GitHub > < #65 (comment)>, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AAM4YWSXYC2MQGGUZO3LXCDRHUAY7ANCNFSM4KRE47GA > > . > -- *John Scharber* *Founder/CEO* *j ***@***.*** ***@***.***>* *https://github.com/jscharber <https://github.com/jscharber>* *(925) 200-7231* — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#65 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANA4GPFHZTSDX6UTPXFC4TDRHUF6HANCNFSM4KRE47GA> .