Giters

paulirish / trace.cafe

easy webperf trace sharing

Home Page:https://trace.cafe/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Download broke

paulirish opened this issue · comments

commented

It broke when I rolled from 112 to 117.
It's cuz of https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4381791

exception:

Error: Failed to execute 'showSaveFilePicker' on 'Window': Cross origin sub frames aren't allowed to show a file picker.

chromium source: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/file_system_access/global_file_system_access.cc;l=189;drc=dbf0295f91fe41035e15d8d6d9e7cdc7f674d2a5

Will either have to check for this case within dt or trace-cafe can provide its own download button.

commented

We can use the real button now that https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5146853 is in

dda7843 reverted the jank replacement download button. yay