pastas / pastastore

:spaghetti: :convenience_store: Tools for managing timeseries and Pastas models

Home Page:https://pastastore.readthedocs.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Towards Pastas 1.0 with some backwards compatibility

dbrakenhoff opened this issue · comments

Pastas 1.0 will introduce some breaking changes to the pas-files format, meaning that pastas models created with pastas<=0.22.0 cannot be loaded with pastas 1.0. This has direct implications for pastastore as well since we use pastas to read/write the models.

How do we deal with this?

  • First of all, add support for Pastas versions 0.23.0 and 1.0 --> I think I have this ready, PR will follow shortly.
  • Pastastore should not care what version of pastas is running and still be able to run all tests --> add different pastas versions to tests?
  • For users with databases created with pastas<=0.22.0, provide a method to update all pas-files. This will require pastas v0.23.0, and basically reads all models and writes them back into the database. A warning should be added that this method is not guaranteed to cover all cases, and it is preferable to reconstruct the models with a script.
  • Pastastore should throw errors when older versions of pas files are read from the database when the pastas version does not match. --> I'm assuming pastas will throw this error for us and we don't need to include any extra logic in pastastore.

If anyone is reading along and I'm missing something, feel free to add it here.

Closed by #80.