passff / passff

zx2c4 pass manager extension for Firefox, Chrome and Opera

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Chrome Port

Immortalin opened this issue · comments

commented

Hi, can you make a port of this to chrome?

No, I can't.
I don't have even enough time to deal with all the issues of the Firefox version.
But if you want to implement a chrome/chromium version of the plugin, or if you know someone who want, you're very welcome ^_^

This may be relatively easy once the addon has been ported to use the new addon API's. I suggest we leave this open for later evaluation.

For people that are looking for a temporary replacement of PassFF over chrome, until the port is effective: Browserpass

Now that we are on WebExtensions, it should be compatible with Chrome. Has anybody tried this yet?

I just tried it with Chrome today and it's complaining that our translation keys are invalid. Apparently Chrome doesn't allow dots in the names, only letters, numbers and underscores. Should be a quick fix, but I don't have time right now to test it. I'll get back to this

Chromium loads the extension with #213. I think it might only need the webextension-polyfill to run correctly (it fixes browser vs chrome namespace issues and Promise vs callback discrepancies).

I have randomly found another extension for chrome/chromium: chrome-pass

I had a look into chrome support using webextension-polyfill version 0.1.2 which looks good already. However, I did not get the native messaging host app running and ran into errors about "disconnected ports" - probably related to the browser messaging API.

Since I don't use Chrome or Chromium, I'm not willing to put more effort into this. However, if somebody else comes up with a working port, I will be happy to accept a pull request.

While investigating a bug, I randomly found that PassFF has this line https://github.com/passff/passff/blob/master/src/skin/menu.css#L119
which is only compatible with Firefox, and barely "supported" by other browsers. See here

I tested PassFF's toolbar menu without it, but I failed to see any difference. What's the purpose of -moz-appearance: none?

Thanks!

I think I experimented around with the styling of <select> elements when transitioning to the WebExtensions API. At some point I added the -moz-appearance property to be able to have complete control over styling. But maybe it turned out to be unnecessary in the end. If you are sure that it doesn't change anything, feel free to remove it in the future...

is this on chrome extension store yet?

No, since it's not working with Chrome or Chromium.