add support for check_run, check_suite ?

Question

add support for check_run, check_suite ?

brad-decker opened this issue 5 years ago · comments

I need to hook into merge when check_run or check_suite actions are called because we use circle ci with github checks and it doesn't post status updates to the commits to trigger on 'status' when this feature is enabled. Thoughts?

Ben Chambers · Answer 1 · Sat Sep 21 2019 00:59:52 GMT+0800 (China Standard Time)

Any update on this? It would be helpful for running in response to CircleCI checks.

Pascal · Answer 2 · Sat Sep 21 2019 23:54:50 GMT+0800 (China Standard Time)

Sorry, I thought I had already replied!

I'm not sure about this feature: We're also using Circle CI, and when a build finished, the status event is triggered just fine. As it says in the documentation:

As an example, one common use is for continuous integration services to mark commits as passing or failing builds using status.

Pascal · Answer 3 · Sat Sep 21 2019 23:56:20 GMT+0800 (China Standard Time)

By the way, I'm not against this feature. There's already a PR #8, but no reply there so far

Pascal · Answer 4 · Sun Nov 10 2019 02:15:23 GMT+0800 (China Standard Time)

This still isn't fixed, but I've added this as limitation to the README for now

Pascal · Answer 5 · Wed Apr 01 2020 20:49:33 GMT+0800 (China Standard Time)

I think this was fixed with #60. However, feel free to reopen this or create a new issue if you disagree or if there are any other problems! 👍

Assaf Yifrach · Answer 6 · Wed Apr 22 2020 19:05:32 GMT+0800 (China Standard Time)

@pascalgn For protected branches it still does not merge.

Pascal · Answer 7 · Wed Apr 22 2020 21:34:22 GMT+0800 (China Standard Time)

Are you sure that's related to the check_run/check_suite events? Or is it a separate issue?